Skip to content

Add CPython 3.9 wheels. #18842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Add CPython 3.9 wheels. #18842

merged 1 commit into from
Nov 10, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 29, 2020

PR Summary

Note, this does mean that our Python 3.9 wheels will be built against NumPy 1.19, because there are no older wheels available.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • [n/a] Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added the Build label Oct 29, 2020
@QuLogic QuLogic added this to the v3.3.3 milestone Oct 29, 2020
@tacaswell
Copy link
Member

Building against np 1.19 does leave a bit of a support gap where someone could have installed from source an older numpy and then pip installed our wheel, but they always have the fall-back of building mpl from source as well.

@jarrodmillman
Copy link
Contributor

Any idea when you will release 3.9 wheels? I am hoping to release NetworkX 2.6 in December. We've recently made Matplotlib a default dependency (previously it was optional). We plan to support 3.9 with our 2.6 release. Matplotlib wheels for 3.9 is our last task before NetworkX officially support 3.9.

No rush, just want your rough estimate so I can have a better handle on our release plans.

@orome
Copy link

orome commented Nov 5, 2020

Any idea when you will release 3.9 wheels?
[...]
No rush, just want your rough estimate so I can have a better handle on our release plans.

It would indeed be great to know this so we can plan our releases.
Is there a roadmap somewhere that would indicate when Matplotlib will work with 3.9?

@tacaswell
Copy link
Member

"Soon", definitely before December.

I do want to stress that Matplotlib works with py39, it is the packaging that is not done.

@orome
Copy link

orome commented Nov 5, 2020

"Soon", definitely before December.

Excellent!

I do want to stress that Matplotlib works with py39, it is the packaging that is not done.

Yes what "works" depends on use case of course. My focus was on something that worked with the vast majority of package consumers (esp. consumers of packages for which Matplotlib is just a dependency), for whom "works" means pip install works.

@cbrnr
Copy link
Contributor

cbrnr commented Nov 9, 2020

It seems like this should be ready because all tests pass - looking forward to finally moving to Python 3.9! Big thanks for providing this great package 👍!

@jklymak
Copy link
Member

jklymak commented Nov 9, 2020

I don't know if the tests passing means anything. @QuLogic any hints for how we can tell if this is working?

@QuLogic
Copy link
Member Author

QuLogic commented Nov 9, 2020

These would only run on the main branches, not PRs; here is a (somewhat older) build on master and one on v3.3.x.

@tacaswell tacaswell merged commit 1eb3d80 into matplotlib:master Nov 10, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 10, 2020
@QuLogic QuLogic deleted the py39 branch November 10, 2020 20:32
QuLogic added a commit that referenced this pull request Nov 11, 2020
…842-on-v3.3.x

Backport PR #18842 on branch v3.3.x (Add CPython 3.9 wheels.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants