-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add CPython 3.9 wheels. #18842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPython 3.9 wheels. #18842
Conversation
Building against np 1.19 does leave a bit of a support gap where someone could have installed from source an older numpy and then pip installed our wheel, but they always have the fall-back of building mpl from source as well. |
Any idea when you will release 3.9 wheels? I am hoping to release NetworkX 2.6 in December. We've recently made Matplotlib a default dependency (previously it was optional). We plan to support 3.9 with our 2.6 release. Matplotlib wheels for 3.9 is our last task before NetworkX officially support 3.9. No rush, just want your rough estimate so I can have a better handle on our release plans. |
It would indeed be great to know this so we can plan our releases. |
"Soon", definitely before December. I do want to stress that Matplotlib works with py39, it is the packaging that is not done. |
Excellent!
Yes what "works" depends on use case of course. My focus was on something that worked with the vast majority of package consumers (esp. consumers of packages for which Matplotlib is just a dependency), for whom "works" means |
It seems like this should be ready because all tests pass - looking forward to finally moving to Python 3.9! Big thanks for providing this great package 👍! |
I don't know if the tests passing means anything. @QuLogic any hints for how we can tell if this is working? |
…842-on-v3.3.x Backport PR #18842 on branch v3.3.x (Add CPython 3.9 wheels.)
PR Summary
Note, this does mean that our Python 3.9 wheels will be built against NumPy 1.19, because there are no older wheels available.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).