Skip to content

Deprecate @cbook.deprecated and move internal calls to @_api.deprecated #19151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2020
Merged

Deprecate @cbook.deprecated and move internal calls to @_api.deprecated #19151

merged 1 commit into from
Dec 24, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

Followup of moving all API helpers to matplotlib._api (#18657).

@timhoffm timhoffm added this to the v3.3.4 milestone Dec 18, 2020
@timhoffm timhoffm force-pushed the change-deprecated-usage branch from bf99c22 to 93ac48f Compare December 18, 2020 22:29
QuLogic
QuLogic reviewed Dec 19, 2020
View reviewed changes
@timhoffm timhoffm force-pushed the change-deprecated-usage branch 2 times, most recently from 8edda00 to 685c002 Compare December 20, 2020 16:41
@QuLogic
Copy link
Member

QuLogic commented Dec 21, 2020

Test failures are relevant.

@QuLogic QuLogic modified the milestones: v3.3.4, v3.4.0 Dec 21, 2020
@timhoffm timhoffm force-pushed the change-deprecated-usage branch from 685c002 to ba92d08 Compare December 22, 2020 00:50
@timhoffm
Copy link
Member Author

Doc builds fail because of

<unknown>:1: WARNING: py:class reference target not found: mpl_toolkits.axisartist.axisline_style._FancyAxislineStyle.FilledArrow
<unknown>:1: WARNING: py:class reference target not found: mpl_toolkits.axisartist.axisline_style._FancyAxislineStyle.SimpleArrow

Has anybody an idea where that comes from and how to fix it?

@timhoffm timhoffm mentioned this pull request Dec 22, 2020
Merged
1 task
@QuLogic
Copy link
Member

QuLogic commented Dec 22, 2020 •
edited
Loading

Going to ignore the doc failure, as it's not relevant to this PR. Oops, only one approval so scratch that; see #19163 for the doc fix.

@timhoffm timhoffm force-pushed the change-deprecated-usage branch from ba92d08 to fa71a21 Compare December 22, 2020 10:20
@timhoffm
Copy link
Member Author

Rebased to include #19163.

@dopplershift dopplershift merged commit 99e6240 into matplotlib:master Dec 24, 2020
@timhoffm timhoffm deleted the change-deprecated-usage branch December 24, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @dopplershift