Skip to content

Fix broken test re: polar tick visibility. #20177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

Fix broken test re: polar tick visibility. #20177

merged 1 commit into from
May 6, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 6, 2021

PR Summary

Breakage arose from bad interaction between #19994 and #20161.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing topic: polar labels May 6, 2021
@anntzer anntzer added this to the v3.5.0 milestone May 6, 2021
@tacaswell
Copy link
Member

Merging this to un-break CI on one review.

Only docs builds are outstanding.

@tacaswell tacaswell merged commit 564d4fd into matplotlib:master May 6, 2021
@anntzer anntzer deleted the kxytlp2 branch May 6, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar topic: testing
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @tacaswell