Fix polar() regression on second call failure #21131
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
This is a fix for issue #21113 |
|
@beckja Do you feel up to adding a test for this? |
|
Thanks @beckja ! I hope you do not mind, I took the liberty of pushing a slight modification to your test to use unpacking syntax (to make sure that only one thing is returned and to make the rest of the rest read a bit better). Given that I pushed a commit to this PR I probably should not merge it. |
|
@tacaswell appreciate the clean-up. This is my first pull request on any open source project, so grateful for the help. |
|
@beckja You identified a problem, proposed a fix, added a test, and look on track to get merged with only very minor revisions, so you are doing pretty good for your first PR! |
|
Congratulation @beckja on your first Matplotlib PR 🎉 ! Hopefully we will hear from you again. |
Fix polar() regression on second call failure
Fix polar() regression on second call failure
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).