Skip to content

Fix flake8 from #21335 #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Fix flake8 from #21335 #21361

merged 1 commit into from
Oct 15, 2021

Conversation

timhoffm
Copy link
Member

No description provided.

@timhoffm timhoffm added this to the v3.5.0 milestone Oct 15, 2021
@timhoffm timhoffm changed the title Fix flake8 from #21360 Fix flake8 from #21335 Oct 15, 2021
@QuLogic
Copy link
Member

QuLogic commented Oct 15, 2021

The commit message is also wrong.

@timhoffm
Copy link
Member Author

Sorry, I’m away from my PC and cannot update the message. Feel free to push over or merge as is (after all, the commit id is from the backport, so it’s only half off).

@QuLogic QuLogic merged commit 7c6d9eb into matplotlib:master Oct 15, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 15, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.5.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7c6d9ebd1400434a4d67143ff4bf682677ca7e2e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #21361: Fix flake8 from #21335'
  1. Push to a named branch :
git push YOURFORK v3.5.x:auto-backport-of-pr-21361-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR #21361 on branch v3.5.x (Fix flake8 from #21335)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Member

QuLogic commented Oct 15, 2021

I'll just throw the fix into the existing backport in #21360.

@timhoffm timhoffm deleted the fix-flake8 branch October 15, 2021 06:35
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants