Skip to content

Log pixel coordinates in event_handling coords_demo example on terminal/console #21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Log pixel coordinates in event_handling coords_demo example on terminal/console #21389

merged 1 commit into from
Oct 20, 2021

Conversation

jatin837
Copy link
Contributor

@jatin837 jatin837 commented Oct 20, 2021 •
edited
Loading

PR Summary

coords_demo.py example has unused variables for pixel values. This PR attempts to improve this by logging pixel value, alongside axis data on the terminal/console where this specific example is running

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@story645
Copy link
Member

Hi, thanks for the PR! Please edit your post to add a short summary of why you're making these changes.

github-actions[bot]
github-actions bot reviewed Oct 20, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

jklymak
jklymak approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is actually helpful. Thanks!

@jklymak jklymak added this to the v3.6.0 milestone Oct 20, 2021
@jatin837
Copy link
Contributor Author

Hi, thanks for the PR! Please edit your post to add a short summary of why you're making these changes.

thanks @story645 for help. i have added the summary. hope it explains role of my PR.

@jatin837 jatin837 closed this Oct 20, 2021
@jatin837 jatin837 reopened this Oct 20, 2021
@dstansby dstansby merged commit f6e0ee4 into matplotlib:master Oct 20, 2021
@story645
Copy link
Member

Congrats on the PR, hope to see you again! 🎉

@jatin837 jatin837 deleted the unused-pxl-coord branch October 20, 2021 11:56
@jatin837
Copy link
Contributor Author

Congrats on the PR, hope to see you again! 🎉

Yeah definitely @story645 😊

tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@dstansby
Merge pull request #21389 from jatin837/unused-pxl-coord
a1eef38 
Log pixel coordinates in event_handling coords_demo example on terminal/console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jatin837 @story645 @jklymak @dstansby