Skip to content

Check for images added-and-modified in a same PR #21593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 10, 2021

PR Summary

... as is currently the case in #21562.

As in #21359, this currently contains two additional commits at the top that should cause CI to fail; I will edit these commits out of existence once this PR is approved.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.6.0 milestone Nov 11, 2021
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an approval, but I'll stick request changes on it so it doesn't accidentally get merged before you remove the test figure.

@jklymak
Copy link
Member

jklymak commented Nov 13, 2021

@anntzer feel free to self merge when you have the image squashed out....

@anntzer anntzer force-pushed the doubleimg branch 2 times, most recently from 90be1ae to 5f3b113 Compare November 14, 2021 20:47
@anntzer anntzer dismissed dstansby’s stale review November 14, 2021 20:52

images squashed out

@anntzer anntzer merged commit 02f093b into matplotlib:main Nov 14, 2021
@anntzer anntzer deleted the doubleimg branch November 14, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants