Skip to content

Simplify macosx toolbar init. #21717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2021
Merged

Simplify macosx toolbar init. #21717

merged 1 commit into from
Nov 23, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 22, 2021

Pass canvas as argument to __init__, relying on PyArg_ParseTuple to
check type (and non-NULL-ness).

Also declare some variables closer to point of use, and use
NSMakeRect/NSMakeSize to create NSRects and NSSizes.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Simplify macosx toolbar init.
faabfd9 
Pass `canvas` as argument to `__init__`, relying on PyArg_ParseTuple to
check type (and non-NULL-ness).

Also declare some variables closer to point of use, and use
NSMakeRect/NSMakeSize to create NSRects and NSSizes.
@anntzer anntzer marked this pull request as ready for review November 22, 2021 21:27
@QuLogic QuLogic added this to the v3.6.0 milestone Nov 22, 2021
greglucas
greglucas approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice simplification and the toolbar looks the same for me as before on my local system.

@greglucas greglucas merged commit 94ac7a7 into matplotlib:main Nov 23, 2021
@anntzer anntzer deleted the macosxtb2 branch November 23, 2021 01:00
@anntzer anntzer mentioned this pull request Nov 23, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
GUI: MacOSX Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @greglucas