Skip to content

MAINT Fix signature qhull version function #21834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2021
Merged

MAINT Fix signature qhull version function #21834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9edd103
Fix arguments of qhull version function to match expected METH_NOARGS…
hoodmane Dec 2, 2021
893e24b
Remove unneeded cast to PyCFunction
hoodmane Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/qhull_wrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,14 +295,14 @@ delaunay(PyObject *self, PyObject *args)

/* Return qhull version string for assistance in debugging. */
static PyObject*
version(void)
version(PyObject *self, PyObject *arg)
{
return PyBytes_FromString(qh_version);
}

static PyMethodDef qhull_methods[] = {
{"delaunay", (PyCFunction)delaunay, METH_VARARGS, ""},
{"version", (PyCFunction)version, METH_NOARGS, ""},
{"delaunay", delaunay, METH_VARARGS, ""},
{"version", version, METH_NOARGS, ""},
{NULL, NULL, 0, NULL}
};

Expand Down