Re-enable cibuildwheel on push #22375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, we have an issue with NumPy not being pinned; I think that'll be fixed by #22194. |
0753e94 to
38af5a8
Compare
greglucas
approved these changes
Feb 12, 2022
timhoffm
approved these changes
Feb 12, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 12, 2022
dstansby
added a commit
that referenced
this pull request
Feb 12, 2022
…375-on-v3.5.x Backport PR #22375 on branch v3.5.x (Re-enable cibuildwheel on push)
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Feb 24, 2022
I had the wrong condition in matplotlib#22375, so that they were still not triggered on push.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Feb 24, 2022
I had the wrong condition in matplotlib#22375, so that they were still not triggered on push.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Feb 24, 2022
I had the wrong condition in matplotlib#22375, so that they were still not triggered on push.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the previous change #22235, the condition to enable wheels with a label left out pushes, so wheels have not been building on
mainlike they should have been. (and also tags, but we haven't made any.)I'm adding the label now to ensure that things haven't broken in the interim.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).