Skip to content

TST: be more forgiving about IDing Noto #23610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2022
Merged

TST: be more forgiving about IDing Noto #23610

merged 1 commit into from
Aug 13, 2022

Conversation

tacaswell
Copy link
Member

PR Summary

Following up on #23559 to relax the tests on discovering that Noto Sans is installed.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 12, 2022
@jklymak jklymak merged commit 540ab07 into matplotlib:main Aug 13, 2022
@tacaswell tacaswell deleted the tst_noto_relax branch August 13, 2022 15:54
@tacaswell
Copy link
Member Author

This still isn't working on CI, even though it worked for me locally:

SKIPPED [4] lib/matplotlib/tests/test_ft2font.py:66: Font WenQuanYi Zen Hei (wqy-zenhei) is missing
SKIPPED [4] lib/matplotlib/tests/test_ft2font.py:66: Font Noto Sans CJK JP (NotoSansCJK) is missing
SKIPPED [1] lib/matplotlib/tests/test_ft2font.py:92: Font WenQuanYi Zen Hei (wqy-zenhei) is missing
SKIPPED [1] lib/matplotlib/tests/test_ft2font.py:92: Font Noto Sans CJK JP (NotoSansCJK) is missing

@tacaswell tacaswell mentioned this pull request Aug 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @jklymak @oscargus