sphinxext: Do not copy plot_directive.css's metadata #23805
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you @collares and congratulations on your first merged Matplotlib PR 🎉 Hopefully we will hear from you again! |
|
I see now downside to this. |
…805-on-v3.6.x Backport PR #23805 on branch v3.6.x (sphinxext: Do not copy plot_directive.css's metadata)
PR Summary
The Sphinx extension uses
shutil.copyto putplot_directive.cssin the_staticdirectory. In Nix, this copies from the read-only Nix store, which results in a read-onlyplot_directive.cssfile. This causes some problem with SageMath docbuilding, because it deduplicates_staticdirectories with symlinks, resulting in failed overwrite attempts. See NixOS/nixpkgs#189776 for a more detailed description.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).