Improve rubberband rendering in wx and tk #23985
Merged
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1ae8a to
d85b6ee
Compare
oscargus
commented
Oct 15, 2022
| [(x0, y0, x1, y0), (x1, y0, x1, y1), | ||
| (x0, y0, x0, y1), (x0, y1, x1, y1)], | ||
| wx.Pen('BLACK', 1, wx.PENSTYLE_SHORT_DASH)) | ||
| x0, y0, x1, y1 = map(round, self._rubberband_rect) |
There was a problem hiding this comment.
Earlier it was possible that the left and bottom bounds could be one pixel off as int truncates. Using round seems to improve the situation, at least based on practical tests.
timhoffm
approved these changes
Oct 15, 2022
|
I manually tested tk. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 20, 2022
QuLogic
added a commit
that referenced
this pull request
Oct 21, 2022
…985-on-v3.6.x Backport PR #23985 on branch v3.6.x (Improve rubberband rendering in wx and tk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23969 (as there is a separate OSX issue #23777)
Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk backend it messes up the deprecated
lastrectas bit since it only can contain one of the two rectangles. Not sure whatlastrectis used for. If it is only to get the position it should be OK, but if it is to possibly modify the rectangle it may not work.No obvious way to test it in the CI.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).