Skip to content

List all the places to update when adding a dependency. #24298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

List all the places to update when adding a dependency. #24298

merged 1 commit into from
Oct 28, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 28, 2022

There starts to be so many places to update that it's easy to forget one.

At least from my PoV, setup.py is the canonical place; let's not add this list of files next to each copy of the list...

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
List all the places to update when adding a dependency.
ad3787c 
There starts to be so many places to update that it's easy to forget
one.

At least from my PoV, setup.py is the canonical place; let's not add
this list of files next to each copy of the list...
@story645 story645 added this to the v3.6.3 milestone Oct 28, 2022
@story645 story645 merged commit 25d30c2 into matplotlib:main Oct 28, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 28, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 25d30c2e31cbf4ee05fee103e17470bd78d35b77
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24298: List all the places to update when adding a dependency.'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24298-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR #24298 on branch v3.6.x (List all the places to update when adding a dependency.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the ir branch October 28, 2022 21:47
@QuLogic QuLogic modified the milestones: v3.6.3, v3.7.0 Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @story645 @timhoffm @QuLogic