Skip to content

Use std::isnan and fix compiler warning #24575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Dec 1, 2022

PR Summary

Noted this warning while recompiling which lead to the comment about isnan and since we now require C++ 11 anyway...

  In file included from src/_path_wrapper.cpp:3:0:
  src/_path_wrapper.cpp: In function ‘Py_is_sorted(_object*, _object*)’:
  src/_path.h:1275:17: warning: ‘last_value’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   if (current_value < last_value) {
                   ^
  src/_path.h:1253:11: note: ‘last_value’ was declared here
           T last_value;
             ^

The warning seems to be a false positive, but I guess there is limited harm in initializing the variable.

Edit: it seems like newer compilers do not warn for this, but I guess that they then also can detect that the initialization is a nop anyway?

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added this to the v3.7.0 milestone Dec 2, 2022
@QuLogic QuLogic merged commit ccbd641 into matplotlib:main Dec 2, 2022
@oscargus oscargus deleted the isnan branch December 2, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants