Skip to content

MNT: make fig.colorbar(..., ax=INPUT) even more forgiving #24737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2022
Merged

MNT: make fig.colorbar(..., ax=INPUT) even more forgiving #24737

merged 3 commits into from
Dec 16, 2022
+7 −4

Conversation

tacaswell
Copy link
Member

PR Summary

Follow on to #24408

Accept anything that passes np.iterable

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@tacaswell
MNT: make fig.colorbar(..., ax=INPUT) even more forgiving
9c36d85 
Accept anything that passes `np.iterable`
@tacaswell tacaswell added this to the v3.7.0 milestone Dec 15, 2022
rcomer
rcomer reviewed Dec 15, 2022
View reviewed changes
@tacaswell @rcomer
MNT: refactor to remove a level of indentation
bb510b9 
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
rcomer
rcomer reviewed Dec 15, 2022
View reviewed changes
@tacaswell
DOC: call out numpy array specifically
06396e2 
We support higher-dimensional arrays (not clear we _should_ but we do).
@timhoffm
Copy link
Member

Anybody can merge after CI pass.

@QuLogic QuLogic merged commit 7f5335a into matplotlib:main Dec 16, 2022
@tacaswell tacaswell deleted the mnt/forgiving_colorbar_input branch December 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcomer rcomer rcomer approved these changes

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: consistency topic: color/colorbar
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @timhoffm @QuLogic @rcomer