Skip to content

separate out folders in gallery ordering #25028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

story645
Copy link
Member

@story645 story645 commented Jan 19, 2023

Separates each gallery ordering into its own list to make it a little cleaner to find/order each gallery. Should maybe be a conf file but this was a quick proof of concept inspired by ordering being a pain in #24746 (comment)

ETA: I like @QuLogic's idea #24746 (comment) of putting the ordering in each readme better but don't really have the time to implement that...I think it would basically be populate these lists w/ the contents of those readmes

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All optional stylistic comments.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement.

I still feel it is very hard to discover where this order gets set. I like @QuLogic idea of having something in the README.rst that gets scraped.

@jklymak jklymak merged commit be7ea76 into matplotlib:main Jan 19, 2023
@story645 story645 deleted the gallery_order branch January 19, 2023 17:58
@QuLogic QuLogic added this to the v3.8.0 milestone Jul 5, 2023
@ksunden ksunden changed the title seperate out folders in gallery ordering separate out folders in gallery ordering Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: build building the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants