fix FigureCanvasTkAgg memory leak via weakrefs #25097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is worth the risk to backport memory-leak fixes. |
tacaswell
approved these changes
Jan 27, 2023
|
The flake8 is understood and fixed else where already. |
|
This could lead to user breakage since things that were once immortal are now possibly short lived, just like in the original issue. |
|
Maybe that was a hasty comment. They should live until someone calls |
ksunden
reviewed
Feb 3, 2023
|
Okay, having convinced myself that these changes work I think it seems fine. @richardsheridan are you still thinking that things may be too short lived, or was that last comment pretty convinced it is okay? |
|
I'm satisfied that those binds won't be released too early from any practical user perspective. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #24820
May be worth checking if the memory leak tests can be tightened.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst