Skip to content

Fix Lasso line cleanup #25279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix Lasso line cleanup #25279

merged 1 commit into from
Feb 22, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 22, 2023

PR Summary

Modifying Axes.lines is deprecated (and removed in main).

I noticed this while testing #25155.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic
Fix Lasso line cleanup
31dae57 
Modifying Axes.lines is deprecated (and removed in `main`).
@QuLogic QuLogic added this to the v3.7.1 milestone Feb 22, 2023
@jklymak jklymak merged commit 1ac0541 into matplotlib:main Feb 22, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 22, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 22, 2023
@jklymak @meeseeksmachine
Backport PR matplotlib#25279: Fix Lasso line cleanup
f472e94
@QuLogic QuLogic deleted the fix-lasso branch February 22, 2023 19:00
ksunden added a commit that referenced this pull request Feb 23, 2023
@ksunden
Merge pull request #25288 from meeseeksmachine/auto-backport-of-pr-25…
dd18833 
…279-on-v3.7.x

Backport PR #25279 on branch v3.7.x (Fix Lasso line cleanup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @ksunden @oscargus @jklymak