MNT: Use WeakKeyDictionary and WeakSet in Grouper #25352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
504dd7d to
bc31836
Compare
anntzer
reviewed
Mar 1, 2023
anntzer
approved these changes
Mar 1, 2023
Rather than handling the weakrefs ourselves, just use the builtin WeakKeyDictionary instead. This will automatically remove dead references meaning we can remove the clean() method.
bc31836 to
c38c405
Compare
|
Thank you. I think this also fixes a bug in the pickle logic that would leak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Rather than handling the weakrefs ourselves, just use the builtin WeakKeyDictionary and WeakSet instead. This will automatically remove dead references meaning we can remove the clean() method.
Follow-up from: #25332
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst