Skip to content

Backport PR #25442 on branch v3.7.x (Fix disconnection of callbacks when draggable artist is deparented.) #25465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Backport PR #25442 on branch v3.7.x (Fix disconnection of callbacks when draggable artist is deparented.) #25465

merged 1 commit into from
Mar 15, 2023
+22 −17

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Mar 14, 2023 •
edited
Loading

Fix disconnection of callbacks when draggable artist is deparented.

(cherry picked from commit 370547e)

Required manual backport because additional tests for offsetbox were added on main in #24486 .

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@ksunden
Merge pull request matplotlib#25442 from anntzer/rd
4dc3f40 
Fix disconnection of callbacks when draggable artist is deparented.

(cherry picked from commit 370547e)
@ksunden ksunden added this to the v3.7.2 milestone Mar 14, 2023
@ksunden ksunden added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 14, 2023
@QuLogic QuLogic mentioned this pull request Mar 14, 2023
Merged
6 tasks
@oscargus oscargus merged commit 3ef2184 into matplotlib:v3.7.x Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ksunden @oscargus