Skip to content

DOC/BLD: stop using sg head [ci doc] #25487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

DOC/BLD: stop using sg head [ci doc] #25487

merged 1 commit into from
Mar 20, 2023
+2 −5

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 17, 2023

PR Summary

I think SG release 0.12 is compatible with what we need for flexible rst-passing in SG per #25395

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@jklymak jklymak added the Documentation: build building the docs label Mar 17, 2023
@jklymak jklymak force-pushed the doc-bld-stop-sg-main branch from 9d982fd to f1b70ff Compare March 17, 2023 23:12
@jklymak
Copy link
Member Author

jklymak commented Mar 17, 2023

This worked fine, so we don't need to pip install from git here...

@rcomer
Copy link
Member

rcomer commented Mar 18, 2023

Should the pin also be updated in the conda yml?

matplotlib/environment.yml

Line 39 in 78bf53c

- sphinx-gallery>=0.10

@jklymak jklymak force-pushed the doc-bld-stop-sg-main branch from f1b70ff to d5c8f93 Compare March 18, 2023 15:19
@ksunden ksunden added this to the v3.8.0 milestone Mar 20, 2023
@ksunden ksunden merged commit ecf8da3 into matplotlib:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
Documentation: build building the docs
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jklymak @rcomer @ksunden