Fix issue with sketch not working on PathCollection in Agg #25645
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49b3d47 to
b235cbb
Compare
|
Can you try an image test? I think they're recreatable if you use a fixed seed? |
|
We can only control the seed for data generation in NumPy, not the seed for the C++-part. However, there is #13479 which is related. |
|
yeah, I agree with Jody that #13479 (comment) is the correct solution (and also probably out of scope here) |
|
I've realized that sketching is in general not tested that well (if at all). However, although the result is (probably) deterministic at the moment, I think that it is better to add tests as part of implementing seeding. |
1 task
QuLogic
approved these changes
Sep 14, 2024
timhoffm
approved these changes
Sep 20, 2024
|
@oscargus please rebase |
Will sort it out over the weekend. |
b235cbb to
1cd9255
Compare
|
No conflicts during rebase (but apparently a very long/short weekend...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #19693
Seems like sketch was not handled at all for path collections.
Maybe not the nicest code, but my C/C++ is not that good.
If I understand it correctly, sketch isn't really tested (as it is hard to recreate the images?)?
Here is the output anyway:
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst