Skip to content

DOC: contributing and documenting clean ups + community for incubator invites #25913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

DOC: contributing and documenting clean ups + community for incubator invites #25913

merged 1 commit into from
Jun 20, 2023
+97 −90

Conversation

story645
Copy link
Member

@story645 story645 commented May 18, 2023 •
edited
Loading

Sorta went down a rabbit hole of changes here:

  • per call, changed the channel for incubator invite requests to community (pulled this change out into changed incubator invite channel link to community channel #25929)
  • per call, changed contributing->contribute all over
  • following the contributing->contribute, also did a lot of other case switching in contributing and documenting guides
  • added redirects cause changed file names to match cases but this should maybe be reverted...(and I can just add redirects for the case instead)
  • moved the sample data section out of contributing and into writing examples
  • changed up the contributing preamble to make the code/not code a little more balanced

@story645 story645 mentioned this pull request May 18, 2023
Merged
@story645 story645 changed the title contributing and documenting clean ups + community for incubator invites DOC: contributing and documenting clean ups + community for incubator invites May 19, 2023
@story645 story645 mentioned this pull request May 19, 2023
Merged
melissawm
melissawm reviewed May 22, 2023
View reviewed changes
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @story645 - left a couple of optional comments!

QuLogic
QuLogic reviewed May 23, 2023
View reviewed changes
@story645 story645 mentioned this pull request Jun 7, 2023
Merged
@story645
Copy link
Member Author

Hi, pinging on this 'cause there are some changes I've made here that I'd like to incorporate into #26086

@oscargus oscargus merged commit 9b47f81 into matplotlib:main Jun 20, 2023
@story645
Copy link
Member Author

story645 commented Jun 20, 2023 •
edited
Loading

Ack, thanks for the merge but apparently I misspoke and the docs here didn't build so I should probably fix that first 😥 eta: doc break doesn't seem to be related

@story645 story645 deleted the incubator branch June 22, 2023 19:19
@QuLogic QuLogic added this to the v3.8.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@melissawm melissawm melissawm left review comments

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@story645 @QuLogic @melissawm @oscargus