From 8c7a5829e77695c1f80dc176768ddc4bcc092064 Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Thu, 3 Aug 2023 17:02:08 -0400 Subject: [PATCH 1/4] CI: all supported versions of Python are supported by numpy 1.25 As of numpy 1.25.0 we no longer need to pin to the oldest supported versions to make wheels work reliably. --- .github/workflows/cibuildwheel.yml | 4 ++-- pyproject.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml index 16a4ce52e892..65132c847664 100644 --- a/.github/workflows/cibuildwheel.yml +++ b/.github/workflows/cibuildwheel.yml @@ -91,10 +91,10 @@ jobs: runs-on: ${{ matrix.os }} env: CIBW_BEFORE_BUILD: >- - pip install certifi oldest-supported-numpy && + pip install certifi numpy>=1.25 && rm -rf {package}/build CIBW_BEFORE_BUILD_WINDOWS: >- - pip install certifi delvewheel oldest-supported-numpy && + pip install certifi delvewheel numpy>=1.25 && rm -rf {package}/build CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: >- delvewheel repair -w {dest_dir} {wheel} diff --git a/pyproject.toml b/pyproject.toml index b1a82dac4298..d2e2f769b7ef 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -2,7 +2,7 @@ build-backend = "setuptools.build_meta" requires = [ "certifi>=2020.06.20", - "oldest-supported-numpy", + "numpy>=1.25", "pybind11>=2.6", "setuptools>=42", "setuptools_scm>=7", From 8b6e6b36c186243efc5d91b460cddc48514e3589 Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Thu, 3 Aug 2023 16:11:57 -0400 Subject: [PATCH 2/4] BLD: stop skipping musl wheel builds closes #26438 --- .github/workflows/cibuildwheel.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml index 65132c847664..be50b11b77ea 100644 --- a/.github/workflows/cibuildwheel.yml +++ b/.github/workflows/cibuildwheel.yml @@ -102,7 +102,6 @@ jobs: twine check {wheel} && python {package}/ci/check_wheel_licenses.py {wheel} CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014 - CIBW_SKIP: "*-musllinux*" CIBW_TEST_COMMAND: >- python {package}/ci/check_version_number.py # Apple Silicon machines are not available for testing, so silence the From 0b7007ed72f7e5ddf1ceed6b7d8a31bc1ce4ffaa Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Mon, 7 Aug 2023 17:02:20 -0400 Subject: [PATCH 3/4] DOC: add note that we now build musl wheels --- doc/api/next_api_changes/development/26443-TAC.rst | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/api/next_api_changes/development/26443-TAC.rst diff --git a/doc/api/next_api_changes/development/26443-TAC.rst b/doc/api/next_api_changes/development/26443-TAC.rst new file mode 100644 index 000000000000..b7f3bf47573f --- /dev/null +++ b/doc/api/next_api_changes/development/26443-TAC.rst @@ -0,0 +1,7 @@ +New wheel architectures +~~~~~~~~~~~~~~~~~~~~~~~ + + +Wheels have been added for: + +- musl based systems From f49bb652dafc9119bd679b831729a86bd85bcf7a Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Tue, 8 Aug 2023 17:50:50 -0400 Subject: [PATCH 4/4] BLD: do not build musl + arm Co-authored-by: Kyle Sunden --- .github/workflows/cibuildwheel.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml index be50b11b77ea..abcd97592ad6 100644 --- a/.github/workflows/cibuildwheel.yml +++ b/.github/workflows/cibuildwheel.yml @@ -102,6 +102,7 @@ jobs: twine check {wheel} && python {package}/ci/check_wheel_licenses.py {wheel} CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014 + CIBW_SKIP: "*-musllinux_aarch64" CIBW_TEST_COMMAND: >- python {package}/ci/check_version_number.py # Apple Silicon machines are not available for testing, so silence the