Skip to content

moved communications guidelines from governance, updated and clarified process #26703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2023
Merged

moved communications guidelines from governance, updated and clarified process #26703

merged 5 commits into from
Nov 1, 2023
+257 −23

Conversation

story645
Copy link
Member

@story645 story645 commented Sep 6, 2023 •
edited
Loading

There's been an open issue for a while to move the communications guidelines out of the governance repository because it should function more like code or documentation guidelines. In that issue the move was waiting on a new development repo, but I figure as an incremental step it can be moved into the development guidelines section with the other documents that are more geared towards maintainers because maintainers are the audience it is currently written for. I broke up this change into:

  1. move over file and add to index, closes Move the communication guidelines to the (future) development guide repo governance#24
  2. update the guidelines with current info, supercedes Update comms guidelines governance#36
  3. guidelines for changing guidelines, inline with the API guidance, supercedes comm lead should review changes to guidlines governance#31
  4. update the release guide to use the communications channels listed in the comms guide
  5. removed the checklist code from the pr-guideline b/c I made it a class in 4.

attn: @matplotlib/steering-council

@story645 story645 added governance needs approval from @steering-council Documentation: devdocs files in doc/devel labels Sep 6, 2023
@story645 story645 force-pushed the communication_guidelines branch 3 times, most recently from b5c473a to a5c92ce Compare September 24, 2023 07:02
timhoffm
timhoffm reviewed Oct 5, 2023
View reviewed changes
@story645 story645 force-pushed the communication_guidelines branch 2 times, most recently from 94cab67 to 783bb50 Compare October 6, 2023 14:02
@story645
Copy link
Member Author

story645 commented Oct 31, 2023 •
edited
Loading

@timhoffm made all the changes and keep running into instances where it'd be really convenient to be able to cross ref the list of our communications channels 😅

timhoffm
timhoffm reviewed Nov 1, 2023
View reviewed changes
timhoffm
timhoffm approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I‘ve fixed some formatting.

Anybody can merge after CI pass. @story645 do you want to keep the individual commits or can we squash?

@story645
Copy link
Member Author

story645 commented Nov 1, 2023 •
edited
Loading

do you want to keep the individual commits or can we squash?

I'd rather keep them separate here b/c they're all doing different things - but I'll rebase your fixes so it's cleaner. (basically I remembered/learned how to reorder commits)

@story645 story645 force-pushed the communication_guidelines branch from 4caf7c2 to 0887901 Compare November 1, 2023 08:07
@story645
Copy link
Member Author

story645 commented Nov 1, 2023

Also once this gets merged, the comms guide needs to get deleted in governance, but do we add a redirect (and if so where?)

@timhoffm
Copy link
Member

timhoffm commented Nov 1, 2023

Also once this gets merged, the comms guide needs to get deleted in governance, but do we add a redirect (and if so where?)

IMHO a redirect is not necessary. I don’t think the comma guide is something that many people have referenced. Also, redirects are nice for usability but not a strict requirement.

@story645
Copy link
Member Author

story645 commented Nov 1, 2023

I don’t think the comma guide is something that many people have referenced

I send it to people but I think I've always used the repo

@timhoffm timhoffm added this to the v3.8-doc milestone Nov 1, 2023
@timhoffm timhoffm merged commit ca1880b into matplotlib:main Nov 1, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 1, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 1, 2023
@timhoffm @meeseeksmachine
Backport PR matplotlib#26703: moved communications guidelines from go…
13bb274 
…vernance, updated and clarified process
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 1, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 1, 2023
@timhoffm @meeseeksmachine
Backport PR matplotlib#26703: moved communications guidelines from go…
3598222 
…vernance, updated and clarified process
This was referenced Nov 1, 2023
Closed
Closed
QuLogic added a commit that referenced this pull request Nov 1, 2023
@QuLogic
Merge pull request #27247 from meeseeksmachine/auto-backport-of-pr-26…
94b2ca1 
…703-on-v3.8.x

Backport PR #26703 on branch v3.8.x (moved communications guidelines from governance, updated and clarified process )
QuLogic added a commit that referenced this pull request Nov 1, 2023
@QuLogic
Merge pull request #27248 from meeseeksmachine/auto-backport-of-pr-26…
97fbc94 
…703-on-v3.8.1-doc

Backport PR #26703 on branch v3.8.1-doc (moved communications guidelines from governance, updated and clarified process )
story645 added a commit to story645/governance that referenced this pull request Nov 2, 2023
@story645
moved communications to main docs xref: matplotlib/matplotlib#26703
39eb9d6
@story645 story645 deleted the communication_guidelines branch November 2, 2023 00:33
@story645 story645 mentioned this pull request Nov 2, 2023
Merged
story645 added a commit to story645/governance that referenced this pull request Nov 2, 2023
@story645
moved communications to main docs xref: matplotlib/matplotlib#26703
c8827fc
story645 pushed a commit to story645/matplotlib that referenced this pull request Nov 2, 2023
@timhoffm @story645
Merge pull request matplotlib#26703 from story645/communication_guide…
ec14e72 
…lines

moved communications guidelines from governance, updated and clarified process
@story645 story645 mentioned this pull request Nov 2, 2023
Merged
1 task
story645 added a commit to story645/governance that referenced this pull request Nov 2, 2023
@story645
moved communications to main docs xref: matplotlib/matplotlib#26703
f9c870d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@efiring efiring Awaiting requested review from efiring

@dopplershift dopplershift Awaiting requested review from dopplershift

Assignees
No one assigned
Labels
Documentation: devdocs files in doc/devel governance needs approval from @steering-council
Projects
None yet
Milestone
v3.8-doc
Development

Successfully merging this pull request may close these issues.

Move the communication guidelines to the (future) development guide repo
2 participants
@story645 @timhoffm