Skip to content

ci: Run mypy against typed cycler #26943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

ci: Run mypy against typed cycler #26943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ jobs:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -o pipefail
# The --ignore-missing-imports can be removed when typed cycler is released and used
mypy --config pyproject.toml lib/matplotlib \
--ignore-missing-imports \
--follow-imports silent | \
reviewdog -f=mypy -name=mypy \
-tee -reporter=github-check -filter-mode nofilter
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ exclude = [
# stubtest will import and run, opening a figure if not excluded
".*/tinypages",
]
ignore_missing_imports = true
enable_incomplete_feature = [
"Unpack",
]
Expand Down