-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[Doc]: Move Automated Tests section to workflow docs #26998 #27093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I added a short sentence adding some context, you're welcome to make that change or leave it for a follow up. Just let me know.
Co-authored-by: hannah <story645@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the html has to build. Look at our codespaces if you can't/don't want to build locally
https://matplotlib.org/devdocs/devel/contribute.html#how-to-contribute
Co-authored-by: hannah <story645@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight spacing nit but otherwise good to go.
Co-authored-by: hannah <story645@gmail.com>
Congrats on your first merged PR 🥳 we hope to see you again! |
Thank you @story645 . Definitely looking forward to do more contributions. |
PR summary
Fixes #26998
PR checklist