Skip to content

Update developer release guide to follow conventions #27118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2023
Merged

Update developer release guide to follow conventions #27118

merged 2 commits into from
Oct 18, 2023

Conversation

0taj
Copy link
Contributor

@0taj 0taj commented Oct 17, 2023

PR summary

Updated the developer release guide to follow the matplotlib formatting standards and conventions (https://matplotlib.org/devdocs/devel/document.html#section-formatting). This PR closes one of tasks listed in the issue #26862

PR checklist

github-actions[bot]
github-actions bot reviewed Oct 17, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

story645
story645 previously requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, one small change to make :)

@0taj @story645
Update doc/devel/release_guide.rst
965b28f 
Co-authored-by: hannah <story645@gmail.com>
@QuLogic
Copy link
Member

QuLogic commented Oct 18, 2023 •
edited
Loading

Please use a more descriptive PR title/commit message than GitHub's default, in the future.

@QuLogic QuLogic changed the title Update doc/devel/release_guide.rst Update developer release guide to follow conventions Oct 18, 2023
@QuLogic QuLogic dismissed story645’s stale review October 18, 2023 01:21

Change was made

@QuLogic QuLogic added this to the v3.8.1 milestone Oct 18, 2023
@QuLogic QuLogic merged commit 103ca38 into matplotlib:main Oct 18, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 18, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 18, 2023
@0taj @meeseeksmachine
Backport PR matplotlib#27118: Update developer release guide to follo…
214ebb0 
…w conventions
@QuLogic
Copy link
Member

QuLogic commented Oct 18, 2023

Thanks @0taj! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

PS, your macbook is committing with junpeiota@Junpeis-MacBook-Pro.local; you probably will want to configure your git to use your real email address (or the hidden one that GitHub provides)

@QuLogic QuLogic mentioned this pull request Oct 18, 2023
Closed
16 tasks
story645 added a commit that referenced this pull request Oct 18, 2023
@story645
Merge pull request #27131 from meeseeksmachine/auto-backport-of-pr-27…
bfa2e0a 
…118-on-v3.8.x

Backport PR #27118 on branch v3.8.x (Update developer release guide to follow conventions)
@ksunden ksunden mentioned this pull request Nov 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 left review comments

Assignees
No one assigned
Labels
None yet
Projects
First Time Contributors
Status: Merged
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@0taj @QuLogic @story645