BLD: Update Qhull location in branch 3.8.x #28125
Conversation
Change similar too matplotlib#27505 but on the branch 3.8.x as right now the qhull website seems unable to properly deliver the tarball without disconnecting in the middle.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
I've not had the same problems downloading from the old site, but we made this change because it was reported previously, so may as well...
That said, there are not any planned releases for the 3.8 series left, so the impact of this change is pretty limited. (The 3.9 rc is released) (Certain bugs we may still backport, but none that we already know about)
The version name change/hash are consistent with the other PR.
Unfortunately the tarballs are not identical, in which we could have just put both urls.
In all, no real objection to doing the same as we do on main here, though.
PR summary
Change similar to #27505 but on the branch 3.8.x as right now the qhull website seems unable to properly deliver the tarball without disconnecting in the middle. Right now I am unable to build matplotlib from
pip install.I have no actual ticket for this on branch 3.8, but this is exactly the same issue as in #27159 however with the previous (ie non-meson) build system.
PR checklist