FIX: Make array_view.size return 0 for empty arrays #5264
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API change that seems somewhat illogical to me, but it probably avoids errors like #5185 without fixes like #5241, which seems more puzzling to me. What I mean by illogical is that a sequence with a nonzero number of zero-sized elements is presented as having length 0. But making it consistent in that corner case is probably more puzzling to code using
array_view
than returning the actual number of empty elements.