CI: try explicitly including msvc_runtime #6116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac3d2b3 to
f15adc6
Compare
| @@ -68,7 +68,7 @@ install: | |||
| - cmd: copy "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\vcvars64.bat" "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\bin\amd64\vcvarsamd64.bat" | |||
|
|
|||
| # same things as the requirements in ci/conda_recipe/meta.yaml | |||
| - cmd: conda create -y -q -n test-environment python=%PYTHON_VERSION% pip setuptools numpy python-dateutil freetype msinttypes tk pyparsing pytz tornado libpng zlib pyqt cycler nose mock | |||
| - cmd: conda create -y -q -n test-environment python=%PYTHON_VERSION% pip setuptools numpy python-dateutil freetype msinttypes tk pyparsing pytz tornado libpng zlib pyqt cycler nose mock msvc_runtime | |||
There was a problem hiding this comment.
IMO this isn't necessary, the fix is the libpng (without # [unix]) line below?
There was a problem hiding this comment.
ok, strike that this seems to be fixing the 3.3 error, I looked only at the 27 one?
|
IMO this should be merged... Maybe the conda ppl can shed some light why this is only now failing... OR if the msvc dependency it the right thing to do... |
|
Ok lets merge this. If it can be done in a more clean way we can change it again |
jenshnielsen
added a commit
that referenced
this pull request
Mar 6, 2016
CI: try explicitly including msvc_runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might solve #6115