Minor fixes to plot_directive. #9425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The `plot_directive` function was reusing the module's docstring, but the latter is not valid numpydoc. Replace by a short stub pointing to the module docstring. 2. jinja2 is a requirement of sphinx since 2008 (sphinx-doc/sphinx@eeb494c), so we can reasonably drop the code to support jinja1.
dstansby
approved these changes
Oct 17, 2017
|
The git log looks correct 🤷♂️ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot_directivefunction was reusing the module's docstring, butthe latter is not valid numpydoc. Replace by a short stub pointing
to the module docstring.
Thanks to @NelleV who pointed this out in #9149.
so we can reasonably drop the code to support jinja1.
PR Summary
PR Checklist