From d257c135d1f0230d20d60bc6cf3c6f206813919a Mon Sep 17 00:00:00 2001 From: Antony Lee Date: Sat, 2 Dec 2017 13:42:16 -0800 Subject: [PATCH 1/2] Deprecate unused FigureManagerBase.show_popup. --- doc/api/api_changes/2017-12-02-AL.rst | 3 +++ doc/devel/MEP/MEP27.rst | 3 --- lib/matplotlib/backend_bases.py | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 doc/api/api_changes/2017-12-02-AL.rst diff --git a/doc/api/api_changes/2017-12-02-AL.rst b/doc/api/api_changes/2017-12-02-AL.rst new file mode 100644 index 000000000000..7a7b5d2ef49e --- /dev/null +++ b/doc/api/api_changes/2017-12-02-AL.rst @@ -0,0 +1,3 @@ +Deprecations +```````````` +The unused ``FigureManagerBase.show_popup`` method is deprecated. diff --git a/doc/devel/MEP/MEP27.rst b/doc/devel/MEP/MEP27.rst index 57b0540a4c91..63592cf475a3 100644 --- a/doc/devel/MEP/MEP27.rst +++ b/doc/devel/MEP/MEP27.rst @@ -114,9 +114,6 @@ The description of this MEP gives us most of the solution: +--------------------------------------+------------------------------+---------------------+--------------------------------+ |key_press |key_press | | | +--------------------------------------+------------------------------+---------------------+--------------------------------+ -|show_popup |show_poup | |Not used anywhere in mpl, and | -| | | |does nothing. | -+--------------------------------------+------------------------------+---------------------+--------------------------------+ |get_window_title | |get_window_title | | +--------------------------------------+------------------------------+---------------------+--------------------------------+ |set_window_title | |set_window_title | | diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py index 25afd45238bd..37757620c2e5 100644 --- a/lib/matplotlib/backend_bases.py +++ b/lib/matplotlib/backend_bases.py @@ -2696,6 +2696,7 @@ def key_press(self, event): if rcParams['toolbar'] != 'toolmanager': key_press_handler(event, self.canvas, self.canvas.toolbar) + @cbook.deprecated("2.2") def show_popup(self, msg): """Display message in a popup -- GUI only.""" From 7c4cecd06685c580cbdc1757b6d07514b06625fe Mon Sep 17 00:00:00 2001 From: Thomas A Caswell Date: Sat, 2 Dec 2017 20:45:33 -0500 Subject: [PATCH 2/2] DOC: update deprecation note. Add context to where this method came from. --- doc/api/api_changes/2017-12-02-AL.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/api/api_changes/2017-12-02-AL.rst b/doc/api/api_changes/2017-12-02-AL.rst index 7a7b5d2ef49e..2fabbc598824 100644 --- a/doc/api/api_changes/2017-12-02-AL.rst +++ b/doc/api/api_changes/2017-12-02-AL.rst @@ -1,3 +1,6 @@ Deprecations ```````````` -The unused ``FigureManagerBase.show_popup`` method is deprecated. + +The unused ``FigureManagerBase.show_popup`` method is deprecated. This +introduced in e945059b327d42a99938b939a1be867fa023e7ba in 2005 but never built +out into any of the backends.