Use integer bins for integer data in HistogramWidget
#244
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
requested changes
Jan 11, 2024
dstansby
requested changes
Jan 13, 2024
2ca397b to
71f6716
Compare
p-j-smith
commented
Jan 15, 2024
p-j-smith
commented
Jan 15, 2024
Update baseline images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #239
dtypefornp.linspacewhen creating bins forHistogramWidget(so integer bin limits are used for integer images)test_histogram_2Dtest to fail (as the test layer has integer data but float bins were being used) so I've updated the baseline image