Remove some vestigial convenience code.

mattmoor · mattmoor · commit fa0d7b22a1ca · 2017-09-05T22:28:03.000Z
Elaborate on why the TODO to rewrite {pip,whl}.sh as Python is harder than it looks.
diff --git a/python/pip.sh b/python/pip.sh
@@ -14,7 +14,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# TODO(mattmoor): Rewrite this in Python.
+# TODO(mattmoor): Ideally we'd rewrite this in Python for portability, but
+# since the executes during WORKSPACE instantiation that would require
+# redistributing PAR files, since we cannot invoke built tools at that time.
 NAME="$1"
 REQUIREMENTS_TXT="$2"
 REQUIREMENTS_BZL="$3"
@@ -69,7 +71,7 @@ done)
 _packages = {
 $(for p in ${PACKAGES}; do
   whl="$(basename ${p})"
-  echo "\"$(package_name ${whl})\": \"@$(repository_name ${whl})//lib\","
+  echo "\"$(package_name ${whl})\": \"@$(repository_name ${whl})//:pkg\","
 done)
 }
 
diff --git a/python/whl.sh b/python/whl.sh
@@ -15,7 +15,9 @@
 # limitations under the License.
 
 
-# TODO(mattmoor): Rewrite this in Python.
+# TODO(mattmoor): Ideally we'd rewrite this in Python for portability, but
+# since the executes during WORKSPACE instantiation that would require
+# redistributing PAR files, since we cannot invoke built tools at that time.
 WHL="$1"
 REQUIREMENTS="$2"
 PKG=$(basename "${WHL}" | cut -d'-' -f 1)
@@ -72,21 +74,9 @@ py_library(
   deps = [$(
   DELIM=
   for d in ${DEPS[@]}; do
-    # Use the dictionary?
     echo -n "${DELIM}packages(\"${d}\")"
     DELIM=,
   done
   )],
 )
 EOF
-
-# A convenience for terseness.
-mkdir lib
-cat > "lib/BUILD" <<EOF
-package(default_visibility = ["//visibility:public"])
-
-py_library(
-  name = "lib",
-  deps = ["//:pkg"],
-)
-EOF
