-
-
Notifications
You must be signed in to change notification settings - Fork 593
Comparing changes
Open a pull request
base repository: bazel-contrib/rules_python
base: main
head repository: mattmoor/rules_python
compare: master
- 15 commits
- 36 files changed
- 1 contributor
Commits on Sep 5, 2017
-
Check in an initial version of the pip rules.
This is broken off of my prototype repository, and there are a handful of TODOs left to resolve.
Configuration menu - View commit details
-
Copy full SHA for 13c47f3 - Browse repository at this point
Copy the full SHA 13c47f3View commit details -
Remove some vestigial convenience code.
Elaborate on why the TODO to rewrite {pip,whl}.sh as Python is harder than it looks.
Configuration menu - View commit details
-
Copy full SHA for fa0d7b2 - Browse repository at this point
Copy the full SHA fa0d7b2View commit details
Commits on Sep 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 25c78ac - Browse repository at this point
Copy the full SHA 25c78acView commit details
Commits on Sep 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1aafd84 - Browse repository at this point
Copy the full SHA 1aafd84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56be8e8 - Browse repository at this point
Copy the full SHA 56be8e8View commit details
Commits on Sep 10, 2017
-
Migrate pip.sh into piptool.py
This migrates the logic from pip.sh into piptool.py, which should improve portability by removing the bash dependency. This also has the beginnings of wrapping piptool as a closed redistributable that doesn't rely on a system-installed copy of PIP, but instead uses these rules to pull pip into a PAR bundle. Besides needing to work out the details of releasing and redistributing the PAR, we have two unresolved issues: * When bundled as a PAR (vs. py_binary), piptool seems to pick up the system-installed version of pip. * When bundled as a PAR, piptool sometimes sees cert issues resolving requirements (similar to what we see with httplib2).
Configuration menu - View commit details
-
Copy full SHA for b44ba59 - Browse repository at this point
Copy the full SHA b44ba59View commit details -
Address the cert issue in piptool as a PAR.
With this change I am able to build/test my PR on my macbook without pip installed. The only additional change I have locally is to switch from running piptool.py as a simple .py file to downloading/using a PAR built from this change. I believe we still have the problem that the .par picks the host's version of pip instead of our embedded copy, but I haven't reverified that issue still exists (this just does nothing to address that issue).
Configuration menu - View commit details
-
Copy full SHA for 0583d27 - Browse repository at this point
Copy the full SHA 0583d27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07fba0f - Browse repository at this point
Copy the full SHA 07fba0fView commit details
Commits on Sep 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fb08ab4 - Browse repository at this point
Copy the full SHA fb08ab4View commit details
Commits on Sep 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for dad7984 - Browse repository at this point
Copy the full SHA dad7984View commit details -
move python tools under a top-level rules_python package simplify version_test
Configuration menu - View commit details
-
Copy full SHA for 880a2fc - Browse repository at this point
Copy the full SHA 880a2fcView commit details
Commits on Sep 15, 2017
-
Adopt a canonical naming format for imported whl_library rules.
`whl_library` rules generated by `pip_import` are now named as: ``` pypi__{distribution}_{version} ``` Substituting illegal characters (e.g. `-`, `.`) with underscores.
Configuration menu - View commit details
-
Copy full SHA for 182554f - Browse repository at this point
Copy the full SHA 182554fView commit details -
Move the piptool dependency into a .PAR file.
Add a script for updating the tools and document this and the docs script.
Configuration menu - View commit details
-
Copy full SHA for a5d9f83 - Browse repository at this point
Copy the full SHA a5d9f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66a1a92 - Browse repository at this point
Copy the full SHA 66a1a92View commit details -
This was my original name for update_tools.sh, I'd meant to remove it.
Configuration menu - View commit details
-
Copy full SHA for c98e8cb - Browse repository at this point
Copy the full SHA c98e8cbView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...master