Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: mattmoor/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 36 files changed
  • 1 contributor

Commits on Sep 5, 2017

  1. Check in an initial version of the pip rules.

    This is broken off of my prototype repository, and there are a handful of TODOs left to resolve.
    mattmoor committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    13c47f3 View commit details
    Browse the repository at this point in the history
  2. Remove some vestigial convenience code.

    Elaborate on why the TODO to rewrite {pip,whl}.sh as Python is harder than it looks.
    mattmoor committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    fa0d7b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Configuration menu
    Copy the full SHA
    25c78ac View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. Configuration menu
    Copy the full SHA
    1aafd84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56be8e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2017

  1. Migrate pip.sh into piptool.py

    This migrates the logic from pip.sh into piptool.py, which should improve portability by removing the bash dependency.
    
    This also has the beginnings of wrapping piptool as a closed redistributable that doesn't rely on a system-installed copy of PIP, but instead uses these rules to pull pip into a PAR bundle.  Besides needing to work out the details of releasing and redistributing the PAR, we have two unresolved issues:
     * When bundled as a PAR (vs. py_binary), piptool seems to pick up the system-installed version of pip.
     * When bundled as a PAR, piptool sometimes sees cert issues resolving requirements (similar to what we see with httplib2).
    mattmoor committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    b44ba59 View commit details
    Browse the repository at this point in the history
  2. Address the cert issue in piptool as a PAR.

    With this change I am able to build/test my PR on my macbook without pip installed.  The only additional change I have locally is to switch from running piptool.py as a simple .py file to downloading/using a PAR built from this change.
    
    I believe we still have the problem that the .par picks the host's version of pip instead of our embedded copy, but I haven't reverified that issue still exists (this just does nothing to address that issue).
    mattmoor committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    0583d27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07fba0f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2017

  1. Fix a typo in docs

    mattmoor committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    fb08ab4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. Configuration menu
    Copy the full SHA
    dad7984 View commit details
    Browse the repository at this point in the history
  2. Incorporate review feedback

    move python tools under a top-level rules_python package
    
    simplify version_test
    mattmoor committed Sep 12, 2017
    Configuration menu
    Copy the full SHA
    880a2fc View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2017

  1. Adopt a canonical naming format for imported whl_library rules.

    `whl_library` rules generated by `pip_import` are now named as:
    ```
       pypi__{distribution}_{version}
    ```
    
    Substituting illegal characters (e.g. `-`, `.`) with underscores.
    mattmoor committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    182554f View commit details
    Browse the repository at this point in the history
  2. Move the piptool dependency into a .PAR file.

    Add a script for updating the tools and document this and the docs script.
    mattmoor committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    a5d9f83 View commit details
    Browse the repository at this point in the history
  3. Fix buildifier issues.

    mattmoor committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    66a1a92 View commit details
    Browse the repository at this point in the history
  4. Remove update_piptool.sh

    This was my original name for update_tools.sh, I'd meant to remove it.
    mattmoor committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    c98e8cb View commit details
    Browse the repository at this point in the history
Loading