FIX: don't close figures is switch_backend unless really switching

tacaswell · melissawm · commit 7bcdaf38de1a · 2022-12-19T19:13:31.000-03:00
closes matplotlib#14426
diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
@@ -224,7 +224,6 @@ def switch_backend(newbackend):
     global _backend_mod
     # make sure the init is pulled up so we can assign to it later
     import matplotlib.backends
-    close("all")
 
     if newbackend is rcsetup._auto_backend_sentinel:
         current_framework = cbook._get_running_interactive_framework()
@@ -261,6 +260,8 @@ def switch_backend(newbackend):
             switch_backend("agg")
             rcParamsOrig["backend"] = "agg"
             return
+    # have to escape the switch on access logic
+    old_backend = dict.__getitem__(rcParams, 'backend')
 
     backend_mod = importlib.import_module(
         cbook._backend_module_name(newbackend))
@@ -325,6 +326,9 @@ def draw_if_interactive():
     # Need to keep a global reference to the backend for compatibility reasons.
     # See https://github.com/matplotlib/matplotlib/issues/6092
     matplotlib.backends.backend = newbackend
+    if not (isinstance(old_backend, str) and
+            old_backend.lower() == newbackend.lower()):
+        close("all")
 
     # make sure the repl display hook is installed in case we become
     # interactive
diff --git a/lib/matplotlib/tests/test_pyplot.py b/lib/matplotlib/tests/test_pyplot.py
@@ -429,3 +429,14 @@ def test_minor_ticks():
     tick_labels = ax.get_yticklabels(minor=True)
     assert np.all(tick_pos == np.array([3.5, 6.5]))
     assert [l.get_text() for l in tick_labels] == ['a', 'b']
+
+
+def test_switch_backend_no_close():
+    plt.switch_backend('agg')
+    fig = plt.figure()
+    fig = plt.figure()
+    assert len(plt.get_fignums()) == 2
+    plt.switch_backend('agg')
+    assert len(plt.get_fignums()) == 2
+    plt.switch_backend('svg')
+    assert len(plt.get_fignums()) == 0
