std::shared_ptr Memory Leak (espressif#3680)

stickbreaker · web-flow · commit b2c678877c04 · 2020-01-29T12:18:54.000+02:00
* std::shared_ptr Memory Leak clientSocketHande and _rxBuffer are std::shared_ptr, the stop() call was not correctly releasing them and the operator= had similar problems fix for espressif#3679 * operator= second attempt * operator= third time
diff --git a/libraries/WiFi/src/WiFiClient.cpp b/libraries/WiFi/src/WiFiClient.cpp
@@ -196,8 +196,8 @@ WiFiClient & WiFiClient::operator=(const WiFiClient &other)
 
 void WiFiClient::stop()
 {
-    clientSocketHandle = NULL;
-    _rxBuffer = NULL;
+    clientSocketHandle.reset(); // clientSocketHandle = NULL;
+    _rxBuffer.reset(); // _rxBuffer = NULL;
     _connected = false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -196,8 +196,8 @@ WiFiClient & WiFiClient::operator=(const WiFiClient &other)`
`196`	`196`
`197`	`197`	`void WiFiClient::stop()`
`198`	`198`	`{`
`199`		`- clientSocketHandle = NULL;`
`200`		`- _rxBuffer = NULL;`
	`199`	`+ clientSocketHandle.reset(); // clientSocketHandle = NULL;`
	`200`	`+ _rxBuffer.reset(); // _rxBuffer = NULL;`
`201`	`201`	`_connected = false;`
`202`	`202`	`}`
`203`	`203`