feat: add storybook for /deployment/gitauth (#5596)

jsjoeio · web-flow · commit 242676bac33e · 2023-01-06T16:58:20.000Z
* refactor: move GitAuthSettingsPage to dir

* refactor: split page and view GitAuthSettingsPage

* fixup!: formatting

* refactor: narrow props in git auth view

* feat: add storybook for GitAuthSettingsPageView

* fixup: formatting
diff --git a/site/src/AppRouter.tsx b/site/src/AppRouter.tsx
@@ -89,7 +89,10 @@ const UserAuthSettingsPage = lazy(
   () => import("./pages/DeploySettingsPage/UserAuthSettingsPage"),
 )
 const GitAuthSettingsPage = lazy(
-  () => import("./pages/DeploySettingsPage/GitAuthSettingsPage"),
+  () =>
+    import(
+      "./pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage"
+    ),
 )
 const NetworkSettingsPage = lazy(
   () => import("./pages/DeploySettingsPage/NetworkSettingsPage"),
diff --git a/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage.tsx b/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage.tsx
@@ -0,0 +1,21 @@
+import { useDeploySettings } from "components/DeploySettingsLayout/DeploySettingsLayout"
+import React from "react"
+import { Helmet } from "react-helmet-async"
+import { pageTitle } from "util/page"
+import { GitAuthSettingsPageView } from "./GitAuthSettingsPageView"
+
+const GitAuthSettingsPage: React.FC = () => {
+  const { deploymentConfig: deploymentConfig } = useDeploySettings()
+
+  return (
+    <>
+      <Helmet>
+        <title>{pageTitle("Git Authentication Settings")}</title>
+      </Helmet>
+
+      <GitAuthSettingsPageView deploymentConfig={deploymentConfig} />
+    </>
+  )
+}
+
+export default GitAuthSettingsPage
diff --git a/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.stories.tsx b/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.stories.tsx
@@ -0,0 +1,31 @@
+import { ComponentMeta, Story } from "@storybook/react"
+import {
+  GitAuthSettingsPageView,
+  GitAuthSettingsPageViewProps,
+} from "./GitAuthSettingsPageView"
+
+export default {
+  title: "pages/GitAuthSettingsPageView",
+  component: GitAuthSettingsPageView,
+  argTypes: {
+    deploymentConfig: {
+      defaultValue: {
+        gitauth: {
+          name: "Git Auth",
+          usage: "Automatically authenticate Git inside workspaces.",
+          value: [
+            {
+              id: "123",
+              client_id: "575",
+            },
+          ],
+        },
+      },
+    },
+  },
+} as ComponentMeta<typeof GitAuthSettingsPageView>
+
+const Template: Story<GitAuthSettingsPageViewProps> = (args) => (
+  <GitAuthSettingsPageView {...args} />
+)
+export const Page = Template.bind({})
diff --git a/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.tsx b/site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.tsx
@@ -5,24 +5,22 @@ import TableCell from "@material-ui/core/TableCell"
 import TableContainer from "@material-ui/core/TableContainer"
 import TableHead from "@material-ui/core/TableHead"
 import TableRow from "@material-ui/core/TableRow"
+import { DeploymentConfig } from "api/typesGenerated"
 import { AlertBanner } from "components/AlertBanner/AlertBanner"
 import { EnterpriseBadge } from "components/DeploySettingsLayout/Badges"
-import { useDeploySettings } from "components/DeploySettingsLayout/DeploySettingsLayout"
 import { Header } from "components/DeploySettingsLayout/Header"
-import React from "react"
-import { Helmet } from "react-helmet-async"
-import { pageTitle } from "util/page"
 
-const GitAuthSettingsPage: React.FC = () => {
+export type GitAuthSettingsPageViewProps = {
+  deploymentConfig: Pick<DeploymentConfig, "gitauth">
+}
+
+export const GitAuthSettingsPageView = ({
+  deploymentConfig,
+}: GitAuthSettingsPageViewProps): JSX.Element => {
   const styles = useStyles()
-  const { deploymentConfig: deploymentConfig } = useDeploySettings()
 
   return (
     <>
-      <Helmet>
-        <title>{pageTitle("Git Authentication Settings")}</title>
-      </Helmet>
-
       <Header
         title="Git Authentication"
         description="Coder integrates with GitHub, GitLab, BitBucket, and Azure Repos to authenticate developers with your Git provider."
@@ -105,5 +103,3 @@ const useStyles = makeStyles((theme) => ({
     textAlign: "center",
   },
 }))
-
-export default GitAuthSettingsPage

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,10 @@ const UserAuthSettingsPage = lazy(`
`89`	`89`	`() => import("./pages/DeploySettingsPage/UserAuthSettingsPage"),`
`90`	`90`	`)`
`91`	`91`	`const GitAuthSettingsPage = lazy(`
`92`		`- () => import("./pages/DeploySettingsPage/GitAuthSettingsPage"),`
	`92`	`+ () =>`
	`93`	`+ import(`
	`94`	`+ "./pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage"`
	`95`	`+ ),`
`93`	`96`	`)`
`94`	`97`	`const NetworkSettingsPage = lazy(`
`95`	`98`	`() => import("./pages/DeploySettingsPage/NetworkSettingsPage"),`