fix(ci): fix winget package submission (#5630)

matifali · web-flow · commit eb8d5b4408b6 · 2023-01-09T19:46:10.000Z
* fix(ci): fix winget package submission

I removed the step to calculate the version, as somehow the $version was not populated with the version.
Also, GitHub actions suggest removing `:set-output:` as it is deprecated. 

This commit should probably fix the winget package submission using `wingetcreate` cli.

* fixed a typo
diff --git a/.github/workflows/packages.yaml b/.github/workflows/packages.yaml
@@ -15,24 +15,22 @@ jobs:
         run: |
           Invoke-WebRequest https://aka.ms/wingetcreate/latest -OutFile wingetcreate.exe
 
-      # The package version is the same as the tag minus the leading "v".
-      - name: Calculate package version
-        id: version
-        run: |
-          $version = $env:CODER_VERSION -replace "^v", ""
-          echo "::set-output name=version::$version"
-
       - name: Submit updated manifest to winget-pkgs
         run: |
           $release_assets = gh release view --repo coder/coder "$env:CODER_VERSION" --json assets | `
             ConvertFrom-Json
-
+          # Get the installer URL from the release assets.
           $installer_url = $release_assets.assets | `
             Where-Object name -Match ".*_windows_amd64_installer.exe$" | `
             Select -ExpandProperty url
 
           echo "Installer URL: $installer_url"
 
+          # The package version is the same as the tag minus the leading "v".
+          $version = $env:CODER_VERSION -replace "^v", ""
+
+          echo "Package version: $version"
+
           # The URL "|X64" suffix forces the architecture as it cannot be
           # sniffed properly from the URL. wingetcreate checks both the URL and
           # binary magic bytes for the architecture and they need to both match,
@@ -44,7 +42,7 @@ jobs:
           # submission.
           .\wingetcreate.exe update Coder.Coder `
             --submit `
-            --version "${{ steps.version.outputs.version }}" `
+            --version "${version}" `
             --urls "${installer_url}|X64" `
             --token "${{ secrets.CDRCI_GITHUB_TOKEN }}"
 
