Fix scope of dbTTL (coder#5197)

presleyp · web-flow · commit ee74df3d0768 · 2022-12-05T17:19:30.000-05:00
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -672,10 +672,11 @@ func (api *API) putWorkspaceTTL(rw http.ResponseWriter, r *http.Request) {
 	var dbTTL sql.NullInt64
 
 	err := api.Database.InTx(func(s database.Store) error {
+		var validityErr error
 		// don't override 0 ttl with template default here because it indicates disabled auto-stop
-		dbTTL, err := validWorkspaceTTLMillis(req.TTLMillis, 0)
-		if err != nil {
-			return codersdk.ValidationError{Field: "ttl_ms", Detail: err.Error()}
+		dbTTL, validityErr = validWorkspaceTTLMillis(req.TTLMillis, 0)
+		if validityErr != nil {
+			return codersdk.ValidationError{Field: "ttl_ms", Detail: validityErr.Error()}
 		}
 		if err := s.UpdateWorkspaceTTL(ctx, database.UpdateWorkspaceTTLParams{
 			ID:  workspace.ID,
