ref(profiling): Remove use of threading.Event (getsentry#1864)

Zylphrex · web-flow · commit 88880be406e1 · 2023-01-24T11:20:37.000-05:00
Using threading.Event here is too much, just a bool is enough.
diff --git a/sentry_sdk/profiler.py b/sentry_sdk/profiler.py
@@ -629,7 +629,7 @@ def __init__(self, frequency):
         super(ThreadScheduler, self).__init__(frequency=frequency)
 
         # used to signal to the thread that it should stop
-        self.event = threading.Event()
+        self.running = False
 
         # make sure the thread is a daemon here otherwise this
         # can keep the application running after other threads
@@ -638,21 +638,19 @@ def __init__(self, frequency):
 
     def setup(self):
         # type: () -> None
+        self.running = True
         self.thread.start()
 
     def teardown(self):
         # type: () -> None
-        self.event.set()
+        self.running = False
         self.thread.join()
 
     def run(self):
         # type: () -> None
         last = time.perf_counter()
 
-        while True:
-            if self.event.is_set():
-                break
-
+        while self.running:
             self.sampler()
 
             # some time may have elapsed since the last time
@@ -694,29 +692,27 @@ def __init__(self, frequency):
         super(GeventScheduler, self).__init__(frequency=frequency)
 
         # used to signal to the thread that it should stop
-        self.event = threading.Event()
+        self.running = False
 
         # Using gevent's ThreadPool allows us to bypass greenlets and spawn
         # native threads.
         self.pool = ThreadPool(1)
 
     def setup(self):
         # type: () -> None
+        self.running = True
         self.pool.spawn(self.run)
 
     def teardown(self):
         # type: () -> None
-        self.event.set()
+        self.running = False
         self.pool.join()
 
     def run(self):
         # type: () -> None
         last = time.perf_counter()
 
-        while True:
-            if self.event.is_set():
-                break
-
+        while self.running:
             self.sampler()
 
             # some time may have elapsed since the last time
