Skip to content

SoftSPI: Implement 'bits' and 'firstbit' parameters #10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sebert007 opened this issue Mar 10, 2023 · 2 comments
Open

SoftSPI: Implement 'bits' and 'firstbit' parameters #10999

sebert007 opened this issue Mar 10, 2023 · 2 comments
Labels
enhancement Feature requests, new feature implementations

Comments

@sebert007
Copy link

SPI offers both this parameters to specify. SoftSPI rejects both of them, although they are really useful (and needed).

But first probably this issue should be fixed along with it.

#5225
@sebert007 sebert007 added the enhancement Feature requests, new feature implementations label Mar 10, 2023
@robert-hh
Copy link
Contributor

SoftSPI allows to use these parameters at the constructor, but only allow 8 for bits and SPI.MSB for firstbit. So practicall it does not support them. Both look easy to implement (see micropython/drivers/bus/softspi.c and micropython/extmod/machine_spi.c), but someone has to do it and test it.

@robert-hh
Copy link
Contributor

robert-hh commented Mar 11, 2023 •
edited
Loading

But first probably this issue should be fixed along with it. #5225

Maybe there were to many opinions in that discussion, but no conclusion. And then it sticks. I see work has started on that but was never finished: #5542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests, new feature implementations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robert-hh @sebert007