Skip to content

uselect: Issues with polling stream wrappers #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfalcon opened this issue Oct 29, 2017 · 2 comments
Closed

uselect: Issues with polling stream wrappers #3394

pfalcon opened this issue Oct 29, 2017 · 2 comments

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Oct 29, 2017

Currently, uselect module accepts only stream which directly implement MP_STREAM_POLL (baremetal ports) or just exact file and socket streams (unix port). However, these streams can be wrapped in (any number of) other streams, e.g. a socket in websocket in SSL, and such wrapped streams don't work with uselect.

That's apparently what being reported in #3297 .

Solving this on MicroPython level requires a bit of legwork (and associated code), especially given that there're different variants of solution for baremetal vs unix. So, given that uasyncio is the only known component affected, my plan is to try to work it around on its level.

But sooner or later it may affect other users too.

pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue Nov 3, 2017
Poll socket is what's passed to uselect.poll(), while I/O socket is what's
used for .read(). This is a workaround of the issue that MicroPython doesn't
support proxying poll functionality for stream wrappers (like SSL, websocket,
etc.)
This issue is tracked as micropython/micropython#3394

It may be that it's more efficient to apply such a workaround on uasyncio
level rather than implementing full solution of uPy side.
@pfalcon
Copy link
Contributor Author

pfalcon commented Nov 3, 2017

Workaround on uasyncio side: micropython/micropython-lib#227

pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue Nov 3, 2017
Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .
pfalcon added a commit to micropython/micropython-lib that referenced this issue Nov 5, 2017
Poll socket is what's passed to uselect.poll(), while I/O socket is what's
used for .read(). This is a workaround of the issue that MicroPython doesn't
support proxying poll functionality for stream wrappers (like SSL, websocket,
etc.)
This issue is tracked as micropython/micropython#3394

It may be that it's more efficient to apply such a workaround on uasyncio
level rather than implementing full solution of uPy side.
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue Feb 1, 2018
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
@dpgeorge
Copy link
Member

Support for polling ussl objects on bare-metal (axtls and mbedtls versions) was added in 7a67f05 by passing through the ioctl request to the underlying socket object.

Support for polling general objects on unix (including ussl) was implemented in ef554ef

pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue May 3, 2020
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue May 3, 2020
Poll socket is what's passed to uselect.poll(), while I/O socket is what's
used for .read(). This is a workaround of the issue that MicroPython doesn't
support proxying poll functionality for stream wrappers (like SSL, websocket,
etc.)
This issue is tracked as micropython/micropython#3394

It may be that it's more efficient to apply such a workaround on uasyncio
level rather than implementing full solution of uPy side.
pfalcon added a commit to pfalcon/pycopy-lib that referenced this issue May 3, 2020
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
micropython/micropython-lib#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires micropython/micropython-lib#227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants