Skip to content

stmhal: request for file.readlines #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lurch opened this issue May 1, 2014 · 2 comments
Closed

stmhal: request for file.readlines #538

lurch opened this issue May 1, 2014 · 2 comments

Comments

@lurch
Copy link
Contributor

lurch commented May 1, 2014

I quite often find myself doing for line in fileobj.readlines(): rather than the more pythonic (?) for line in fileobj:.
uPy already supports the latter, so presumably it shouldn't be too hard to add the former?
@dpgeorge
Copy link
Member

dpgeorge commented May 3, 2014

Definitely for line in fileobj is better from an efficiency and clarity point of view. But d5f5b2f adds readlines.

@dpgeorge dpgeorge closed this as completed May 3, 2014
@lurch
Copy link
Contributor Author

lurch commented May 3, 2014

Great, thanks! :)

tannewt pushed a commit to tannewt/circuitpython that referenced this issue Feb 13, 2018
@tdicola @tannewt
Add missing Feather M0 RadioFruit boards: RFM69, RFM9x. (micropython#538
3b946f6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lurch @pfalcon @dpgeorge