Skip to content

_thread lock.acquire() timeout not implement ? #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
water5 opened this issue Apr 20, 2020 · 2 comments
Closed

_thread lock.acquire() timeout not implement ? #5945

water5 opened this issue Apr 20, 2020 · 2 comments
Labels
py-core Relates to py/ directory in source

Comments

@water5
Copy link

water5 commented Apr 20, 2020

I try:
lock.acquire(1, 3)

but the lock is acquired unconditionally, the timeout parameter not implement currently?

test environment: ESP32, MicroPython v1.12 on 2019-12-20
@jimmo
Copy link
Member

jimmo commented Apr 20, 2020

the timeout parameter not implement currently?

Not currently implemented.

from modthread.c:

    if (n_args > 1) {
        wait = mp_obj_get_int(args[1]);
        // TODO support timeout arg
    }

@dpgeorge dpgeorge added the py-core Relates to py/ directory in source label Apr 20, 2020
@dpgeorge
Copy link
Member

Closing as a duplicate of #3332.

tannewt pushed a commit to tannewt/circuitpython that referenced this issue Feb 10, 2022
@ladyada
Merge pull request micropython#5945 from EmergReanimator/stm_deinited…
7ba23ff 
…_fix

Fixed common_hal_busio_uart_deinited incorrect pin assignment check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
py-core Relates to py/ directory in source
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimmo @dpgeorge @water5