Skip to content

tests/basics: Add test for cexample module. #10037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

tests/basics: Add test for cexample module. #10037

merged 1 commit into from
Nov 23, 2022

Conversation

laurensvalk
Copy link
Contributor

@laurensvalk laurensvalk commented Nov 21, 2022 •
edited
Loading

This will help us test things like #9997

Edit: Moved test from basics to misc.

@stinos
Copy link
Contributor

stinos commented Nov 21, 2022

There is already a test in extra_coverage, that can maybe be removed then, since now this would be covered anyway?

@laurensvalk
tests/misc: Add test for cexample module.
cdec97b 
This also moves the existing test for cexample.add_ints
originally done in extra_coverage.

Signed-off-by: Laurens Valk <laurens@pybricks.com>
@laurensvalk
Copy link
Contributor Author

There is already a test in extra_coverage, that can maybe be removed then, since now this would be covered anyway?

Thank you, I had missed that one. I've updated the PR.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Nov 23, 2022
@dpgeorge dpgeorge merged commit 1d27c7d into micropython:master Nov 23, 2022
@dpgeorge
Copy link
Member

Looks good, thanks.

@laurensvalk laurensvalk deleted the test-cexample branch November 23, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Relates to tests/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurensvalk @stinos @dpgeorge