tests/misc/cexample_class: Fix timing sensitivity. #10072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
dpgeorge
reviewed
Nov 24, 2022
tests/misc/cexample_class.py
Outdated
| print("Elapsed time should be approx. 100ms but it is", elapsed) | ||
| print(timer) | ||
| print(0 <= t_start <= TOLERANCE_MS) | ||
| print(0 <= t_end <= SLEEP_MS + TOLERANCE_MS) |
There was a problem hiding this comment.
how about a lower bound of SLEEP_MS - TOLERANCE_MS?
Now that the Timer class has been merged in a separate pull request, this can be added to the module test too. Signed-off-by: Laurens Valk <laurens@pybricks.com>
This test could occasionally fail because some operations take longer than expected. This relaxes the timing constraints and defers printing until the very end. Signed-off-by: Laurens Valk <laurens@pybricks.com>
dc3a8e1 to
3c1a2a9
Compare
|
Thank for updating. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test could occasionally fail because some operations take longer than expected. This relaxes the timing constraints and defers printing until the very end.
Signed-off-by: Laurens Valk laurens@pybricks.com
This fixes a follow-up issue raised in #10038
Edit: While we are looking at this code, I've also added the
Timerto thecexamplemodule test.