Skip to content

tests: rename port-specific test dirs to start with port_, and add rp2 specific tests #13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

dpgeorge
Copy link
Member

There are three commits here:

  • rename port-specific tests dirs to begin with port_, to keep the tests dir more organised and prevent possible name clashes with the directories
  • add rp2 specific tests for rp2.DMA
  • extend the existing machine.I2S test to test multiple I2S instances

The aim here is to test more of the rp2 ports peripherals. The new set of tests test currently fail on rp2 due to #13380.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Jan 18, 2024
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f93ffc2) 98.36% compared to head (3b78b37) 98.36%.

❗ Current head 3b78b37 differs from pull request most recent head 51fbec2. Consider uploading reports for the commit 51fbec2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13468   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         159      159           
  Lines       21088    21088           
=======================================
  Hits        20743    20743           
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmo
Copy link
Member

jimmo commented Jan 18, 2024

This looks good!

Just wondering though... is there any reason why we can't do ports/* rather than port_*? (i.e. mirror the way the top-level ports dir is structured).

@dpgeorge
Copy link
Member Author

is there any reason why we can't do ports/* rather than port_*?

Because there were no nested directories in tests/ and I didn't want to start doing that (nested dirs). But that's a pretty weak reason, and it would be neater for tests to match the top-level dir structure.

I will change it to nested dirs.

To keep them all together, mirroring the top-level directory structure.

Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge merged commit 51fbec2 into micropython:master Jan 22, 2024
@dpgeorge dpgeorge deleted the rp2-dma-test branch January 22, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Relates to tests/ directory in source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants